RFR: JDK-8304828: Lots of constant static data not declared static const in cpu/x86

David Holmes dholmes at openjdk.org
Fri Mar 24 05:07:28 UTC 2023


On Thu, 23 Mar 2023 17:31:26 GMT, Justin King <jcking at openjdk.org> wrote:

> Simple refactor that updates declarations and definitions for data that is effectively static and constant to be `static` and/or `const`. Helps make sure we do not break the one definition rule and helps the compiler/linker to place the data in read-only sections of the executable.

Seems okay. I don;t know how disruptive this may be for backports.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13163#pullrequestreview-1356005681


More information about the hotspot-dev mailing list