RFR: JDK-8294266: Add a way to pre-touch java thread stacks [v4]

[Thomas Stuefe]

On Fri, 24 Mar 2023 15:29:27 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test changes, comment change
>
> src/hotspot/share/runtime/javaThread.cpp line 2085:
> 
>> 2083:   // from the current frame down to the start of the shadow zone.
>> 2084:   const address end = _stack_overflow_state.shadow_zone_safe_limit();
>> 2085:   if (is_in_full_stack(end)) {
> 
> Shouldn't we complain to the user here if false?

Possibly, yes. Maybe even an assert.

> src/hotspot/share/runtime/javaThread.cpp line 2088:
> 
>> 2086:     char* p1 = (char*) alloca(1);
>> 2087:     address here = (address) &p1;
>> 2088:     if (is_in_full_stack(here) && here > end) {
> 
> Shouldn't we complain to the user here if false?

Same :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10403#discussion_r1147893495
PR Review Comment: https://git.openjdk.org/jdk/pull/10403#discussion_r1147893791