RFR: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick [v2]
Afshin Zafari
duke at openjdk.org
Mon Mar 27 14:32:27 UTC 2023
On Mon, 27 Mar 2023 14:16:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - order of headers in includes.
>> - order of headers corrected
>
> src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 30:
>
>> 28: #include "asm/macroAssembler.hpp"
>> 29: #include "compiler/disassembler.hpp"
>> 30: #include "metaprogramming/primitiveConversions.hpp"
>
> This needs to be after immediate_aarch64.hpp (alphabetical order).
moved after `memory/..`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13136#discussion_r1149328233
More information about the hotspot-dev
mailing list