RFR: 8303210: [linux, Windows] Make UseSystemMemoryBarrier available as product flag [v6]
Martin Doerr
mdoerr at openjdk.org
Wed Mar 29 10:46:12 UTC 2023
On Wed, 29 Mar 2023 10:36:50 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I'd like to enable UseSystemMemoryBarrier by default on supported Operating Systems in order to improve performance of thread state transitions (I/O, JNI, foreign function calls, JIT compiler threads, etc.). See JBS issue for more details.
>> Unfortunately, the feature was not yet implemented on all platforms. I added the code, but need the platform maintainers to check if it can be used reliably (and ideally if the performance improves). It's easy to switch it off again in case of problems.
>>
>> Update: Startup performance and some benchmarks on some platforms are impacted (see below). So, this PR no longer switches it on by default.
>
> Martin Doerr has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove unintended newline from os_aix.cpp.
> - Remove leftover from os_aix.cpp.
@dholmes: Thanks for reviewing! I had moved the flag initialization to `os_init2()` because of your comment "Actually I think this code belongs in os::init() regardless.", but `os::init()` is too early. I actually agree with that somewhere in arguments.cpp would be nice, but I couldn't find a good place for it there.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12753#issuecomment-1488362131
More information about the hotspot-dev
mailing list