RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

Wed Mar 29 16:59:45 UTC 2023

On Wed, 29 Mar 2023 16:53:39 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - added id to illtrap
>>  - address lutz comment & revert inlining
>>  - Revert "inline asm_assert"
>>  - Revert "inlined assert method"
>>  - Revert "added inline keyword before function implementation"
>
> src/hotspot/cpu/s390/stubRoutines_s390.cpp line 58:
> 
>> 56:     __ z_cgr(table, Z_R0);  // safety net
>> 57:     __ z_bre(L);
>> 58:     __ asm_assert(Assembler::bcondEqual, "crc_table: external word relocation required for load_absolute_address", 0x33);
> 
> How should this `asm_assert` ever get hit? It's preceded by a `bre.`

This was requested change (initially it was not part of this PR).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1152238977