RFR: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp [v3]

Dingli Zhang dzhang at openjdk.org
Thu Mar 30 08:16:22 UTC 2023


On Thu, 30 Mar 2023 07:43:54 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary checking
>
> src/hotspot/cpu/riscv/assembler_riscv.inline.hpp line 49:
> 
>> 47: inline bool Assembler::is_uimm10(uint64_t x) { return is_uimm(x, 10); }
>> 48: 
>> 49: inline bool Assembler::operand_valid_for_add_sub_immediate(int64_t imm) { return is_simm12(imm); }
> 
> Would you mind one more tweak? I think we can also factor out 'Assembler::operand_valid_for_add_sub_immediate' and use 'is_simm12' instead.

Sure! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13202#discussion_r1152896549


More information about the hotspot-dev mailing list