RFR: 8303210: [linux, Windows] Make UseSystemMemoryBarrier available as product flag [v7]

David Holmes dholmes at openjdk.org
Fri Mar 31 05:57:20 UTC 2023


On Thu, 30 Mar 2023 16:53:18 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> I'd like to enable UseSystemMemoryBarrier by default on supported Operating Systems in order to improve performance of thread state transitions (I/O, JNI, foreign function calls, JIT compiler threads, etc.). See JBS issue for more details.
>> Unfortunately, the feature was not yet implemented on all platforms. I added the code, but need the platform maintainers to check if it can be used reliably (and ideally if the performance improves). It's easy to switch it off again in case of problems.
>> 
>> Update: Startup performance and some benchmarks on some platforms are impacted (see below). So, this PR no longer switches it on by default.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move flag configuration and initialization to SystemMemoryBarrier and call it from parse_vm_init_args.

Update looks good. Thanks.

The placement in a .hpp file is not ideal but lacking a cpp file ...

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/12753#pullrequestreview-1366293545


More information about the hotspot-dev mailing list