RFR: JDK-8304815: Use NMT for more precise hs_err location printing [v7]
Thomas Stuefe
stuefe at openjdk.org
Fri Mar 31 09:34:11 UTC 2023
On Fri, 31 Mar 2023 06:14:09 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> life->live
>
> Looks good to me. Feel free to clarify/name the two literals that I mentioned.
> Thanks,
> Roman
Thanks @rkennke !
Your remarks pointed me to a small possible problem where I was stepping through the address range in sizeof(MallocHeader) steps, but that size may theoretically be double the smallest granularity of malloc alignment, so I adjusted that.
I'll wait for the tests to finish, then push.
Cheers, Thomas
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13162#issuecomment-1491624980
More information about the hotspot-dev
mailing list