RFR: 8306034: add support of virtual threads to JVMTI StopThread [v6]

Alan Bateman alanb at openjdk.org
Tue May 2 06:31:26 UTC 2023


On Tue, 2 May 2023 03:17:42 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> We need to account for the `SetLocalXXX` functions with the `depth` parameter which also return `OPAQUE_FRAME` error code for virtual frames. My concern is if the "current frame" part is fully correct.
>
> I've pushed variant from Chris which is a rephrase of what Alan suggested.

I can't help thinking we can do better than "on the thread's current frame" but in the absence of a better suggestion then I think what you have is okay. I think the CSR will need to be edited to sync it up with the wording that has been agreed here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1182132180


More information about the hotspot-dev mailing list