RFR: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled [v4]

Vladimir Kempik vkempik at openjdk.org
Tue May 2 08:10:17 UTC 2023


On Sat, 29 Apr 2023 11:03:25 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused macros
>
> src/hotspot/cpu/riscv/templateTable_riscv.cpp line 2065:
> 
>> 2063:   } else {
>> 2064:     __ ld(temp, Address(temp, 0));
>> 2065:   }
> 
> Similar here. This if-else could be further simplified into a single "__ lwu(temp, Address(temp, 0));" too.

Good catch, thank you

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13645#discussion_r1182221303


More information about the hotspot-dev mailing list