RFR: 8307147: [x86] Dangling pointer warning for Assembler::_attributes
David Holmes
dholmes at openjdk.org
Tue May 2 09:33:15 UTC 2023
On Tue, 2 May 2023 07:54:00 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to work around a false positive -Wdangling-pointer
> warning from gcc13.1. The approach being taken is to suppress the warning,
> with a comment describing why it's a false positive. Also a little code
> restructuring to make it more obvious.
>
> I tried various code modifications to avoid the warning, but they were either
> obscure, large and instrusive, or didn't seem reliably future-proof against
> further changes in gcc's analysis. And that's just for the attempts that
> worked.
>
> Testing:
> mach5 tier1-3 with gcc11.2 (current default in Oracle's CI)
>
> Local (linux-x64) tier1 with gcc13.1, and verified the relevant warnings are
> not reported. This required disabling compiler warnings as errors, as there
> are other new warnings from gcc13.1: JDK-8307210 and JDK-8307196.
Seems reasonable - thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13751#pullrequestreview-1408744780
More information about the hotspot-dev
mailing list