RFR: JDK-8305506: Add support for fractional values of SafepointTimeoutDelay [v4]

[David Holmes]

On Tue, 2 May 2023 09:26:17 GMT, Wojciech Kudla <duke at openjdk.org> wrote:

>> As stated in https://bugs.openjdk.org/browse/JDK-8305506 this change replaces SafepointTimeoutDelay as integer value with a floating point type to support sub-millisecond SafepointTimeout thresholds.
>> This is immensely useful for investigating time-to-safepoint issues in low latency space.
>
> Wojciech Kudla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update full name

Looking good, just one adjustment to the test needed. Thanks.

test/hotspot/jtreg/runtime/CommandLine/DoubleFlagWithIntegerValue.java line 53:

> 51: 
> 52:     // Test double format for -XX:SafepointTimeoutDelay
> 53:     testDoubleFlagWithValue("-XX:SafepointTimeoutDelay", "0.050");

This case doesn't belong in `DoubleFlagWithIntegerValue` as it is not an integer value. I believe this will be covered more broadly by test ` runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java`.

In this test you should follow the existing patter and test e.g. 5 and 5.0

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13373#pullrequestreview-1408768883
PR Review Comment: https://git.openjdk.org/jdk/pull/13373#discussion_r1182330837