RFR: 8307147: [x86] Dangling pointer warning for Assembler::_attributes [v2]

[Kim Barrett]

On Tue, 2 May 2023 09:56:59 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve wording per aph
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 223:
> 
>> 221:   // Record the assembler in the attributes, so the attributes destructor can
>> 222:   // clear the assembler's attributes, cleaning up the otherwise dangling
>> 223:   // pointer.  gcc13 has a false positive warning, as it doesn't tie that
> 
> Suggestion:
> 
>   // pointer.  gcc13 has a false positive warning because it doesn't tie that
> 
> This wording is clearer because it's more definite, IMO.

Sure.  Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13751#discussion_r1183076542