RFR: 8306034: add support of virtual threads to JVMTI StopThread [v8]

Serguei Spitsyn sspitsyn at openjdk.org
Wed May 3 03:03:24 UTC 2023


On Tue, 2 May 2023 18:57:15 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor tweak of JVMTI_ERROR_OPAQUE_FRAME description
>
> src/hotspot/share/prims/jvmti.xml line 1925:
> 
>> 1923:         <error id="JVMTI_ERROR_OPAQUE_FRAME">
>> 1924:           The thread is a suspended virtual thread and the implementation was unable
>> 1925:           to throw an asynchronous exception from this frame.
> 
> This part no longer has wording similar to the general description of JVMTI_ERROR_OPAQUE_FRAME below. Maybe that was understood and intended when the rewording was done. Just want to make sure you are aware of it.

What part of the statement does not match?
Should we say "from the current frame" instead of "from this frame"?

The general description has this:
 "... or the function cannot be performed on the thread's current frame."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1183201230


More information about the hotspot-dev mailing list