RFR: 8306034: add support of virtual threads to JVMTI StopThread [v8]

Serguei Spitsyn sspitsyn at openjdk.org
Wed May 3 03:23:16 UTC 2023


On Wed, 3 May 2023 03:12:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> What part of the statement does not match?
>> Should we say "from the current frame" instead of "from this frame"?
>> 
>> The general description has this:
>>  "... or the function cannot be performed on the thread's current frame."
>
> They are both trying to convey the same thing, but using completely different wording to do so.  One says "the implementation was unable to throw an asynchronous exception", and the other says "the function cannot be performed". One says "from this frame", and the other says "on the thread's current frame". The meaning is the same, but the wording should be consistent.

I feel that it is a feature in the spec to say differently in specific case vs common case.
It should help to understand each case better.
In this particular case, it can be useful to align wording with "the current frame".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1183207895


More information about the hotspot-dev mailing list