RFR: 8307163: JLONG_FORMAT_SPECIFIER should be updated on Windows [v2]

David Holmes dholmes at openjdk.org
Wed May 3 07:30:16 UTC 2023


On Tue, 2 May 2023 12:23:23 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Windows no longer uses I64d anywhere in their newer compilers, instead using the conforming lld specifiers. Minor cleanup here in JLI code to reflect that
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   HotSpot should also use lld instead of I64d

src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 105:

> 103: 
> 104: // Formatting.
> 105: #define FORMAT64_MODIFIER "ll"

Interesting - this seems un-needed and should be replaced in its one use by `INT64_FORMAT_X_0` - but separate PR I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13740#discussion_r1183326100


More information about the hotspot-dev mailing list