RFR: 8305959: Improve itable_stub

Andrew Haley aph at openjdk.org
Thu May 4 09:11:15 UTC 2023


On Thu, 13 Apr 2023 14:33:52 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> Async profiler shows that applications spend up to 10% in itable_stubs.
> 
> The current inefficiency of itable stubs is as follows. The generated itable_stub scans itable twice: first it checks if the object class is a subtype of the resolved_class, and then it finds the holder_class that implements the method. I suggest doing this in one pass: with a first loop over itable, check pointer equality to both holder_class and resolved_class. Once we have finished searching for resolved_class, continue searching for holder_class in a separate loop if it has not yet been found.
> 
> This approach gives 1-10% improvement on the synthetic benchmarks and 3% improvement on Naive Bayes benchmark from the Renaissance Benchmark Suite (Intel Xeon X5675).

Thanks.

For this to be reviewable, we'll need:

A benchmark, and some data.
An explanation of why it's better than the existing implementation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13460#issuecomment-1534359228


More information about the hotspot-dev mailing list