RFR: JDK-8299229: [JVMCI] add support for UseZGC [v6]

Tom Rodriguez never at openjdk.org
Thu May 4 17:36:29 UTC 2023


On Wed, 3 May 2023 16:59:44 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/gc/shared/barrierSetNMethod_riscv.cpp line 85:
>> 
>>> 83:     if (nm->is_compiled_by_jvmci()) {
>>> 84:       _instruction_address = nm->code_begin() + nm->frame_complete_offset();
>>> 85:       _guard_addr = reinterpret_cast<int*>(nm->consts_begin() + nm->jvmci_nmethod_data()->nmethod_entry_patch_offset());
>> 
>> I see 'nm->consts_begin()' is used here to calculate '_guard_addr' for the JVMCI case on riscv. Do you have more details about the design? Thanks.
>
> I forgot to update the riscv version since Graal isn't actually fully working there.  It should look just like the aarch64 code in this regard as the same strategy should work there too.

I've sync'ed the logic with the aarch64 code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11996#discussion_r1185311675


More information about the hotspot-dev mailing list