RFR: JDK-8299229: [JVMCI] add support for UseZGC [v6]

Tom Rodriguez never at openjdk.org
Thu May 4 17:36:32 UTC 2023


On Wed, 3 May 2023 23:06:11 GMT, Andreas Woess <aw at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>> 
>>  - Fix handling of extra data
>>  - Merge branch 'master' into tkr-zgc
>>  - Require nmethod entry barrier emission
>>  - Merge branch 'master' into tkr-zgc
>>  - Use reloc for guard location and read internal fields using HotSpot accessors
>>  - Merge branch 'master' into tkr-zgc
>>  - Remove access to extra data section from Java code
>>  - Handle concurrent unloading
>>  - Merge branch 'master' into tkr-zgc
>>  - Add missing declaration
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/f00a748b...ce19812e
>
> src/hotspot/cpu/x86/gc/shared/barrierSetNMethod_x86.cpp line 194:
> 
>> 192: 
>> 193:   NativeNMethodCmpBarrier* barrier = reinterpret_cast<NativeNMethodCmpBarrier*>(barrier_address);
>> 194:   barrier->verify();
> 
> I think this should be reverted to:
> `debug_only(barrier->verify());`

verify now contains only an assert so the debug_only is unnecessary

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11996#discussion_r1185311292


More information about the hotspot-dev mailing list