RFR: 8307423: [s390x] Represent Registers as values [v2]

Amit Kumar amitkumar at openjdk.org
Fri May 5 02:50:18 UTC 2023


On Fri, 5 May 2023 01:56:27 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> The recent Register implementation uses wild pointer (including null pointer) dereferences which exhibit undefined behavior. We should migrate away from pointer-based representation of Register values as it was done for x86 ([JDK-8292153](https://bugs.openjdk.org/browse/JDK-8292153)). Problems exist when trying to build with GCC 11.3.0 ([JDK-8307093](https://bugs.openjdk.org/browse/JDK-8307093)).
>> 
>> Tested `fastdebug, slowdebug, optimized, release build` , `tier1-test` on fastdebug build and build with GCC-9.5.0 as well.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting & suggestions from @TheRealMDoerr

src/hotspot/cpu/s390/register_s390.hpp line 3:

> 1: /*
> 2:  * Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2016, 2023 SAP SE. All rights reserved.

Hi All, is it okay If I add IBM header as well ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13805#discussion_r1185658967


More information about the hotspot-dev mailing list