RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v14]

Serguei Spitsyn sspitsyn at openjdk.org
Fri May 5 06:05:25 UTC 2023


On Thu, 4 May 2023 23:20:21 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix updates JVMTI FollowReferences implementation to report references from virtual threads:
>> - unmounted vthreads are detected, their stack references for JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
>> - stacks of mounted vthreads are splitted into 2 parts (virtual thread stack and carrier thread stack), references are reported with correct thread id/class tag/object tags/frame depth;
>> - common code to handle stack frames are moved into separate class;
>> 
>> Threads are reported as:
>> - platform threads: JVMTI_HEAP_REFERENCE_THREAD (as before);
>> - mounted vthreads (synthetic references, consider them as heap roots because carrier threads are roots): JVMTI_HEAP_REFERENCE_OTHER;
>> - unmounted vthreads: not reported as heap roots.
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated test

test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp line 39:

> 37:   jint testClassCount;
> 38:   jint *count;
> 39:   jlong *threadId;

Camel case is the Java naming convention for identifiers.
Tests normally use camel case only for native methods which are called from Java.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1185723959


More information about the hotspot-dev mailing list