RFR: 8303942: os::write should write completely [v3]
Afshin Zafari
duke at openjdk.org
Fri May 5 09:03:19 UTC 2023
On Wed, 3 May 2023 11:17:32 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8303942: os::write should write completely
>
> src/hotspot/os/posix/perfMemory_posix.cpp line 109:
>
>> 107: result = os::write(fd, addr, size);
>> 108: if (result == OS_ERR) {
>> 109: if (PrintMiscellaneous && Verbose) {
>
> It's not really part of this issue but since the line is changed, can you change it to unconditionally
> log_info(os)("Could not write...);
> And remove PrintMiscellaneous & Verbose.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13750#discussion_r1185858240
More information about the hotspot-dev
mailing list