RFR: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled [v8]
Feilong Jiang
fjiang at openjdk.org
Fri May 5 12:54:23 UTC 2023
On Fri, 5 May 2023 11:34:00 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:
>> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rename helper function, add assertion
>
> If I remember correctly, there are some misaligned access at string intrinsics. Here are the related PRs at riscv-collab:
>
> - https://github.com/riscv-collab/riscv-openjdk/pull/19
> - https://github.com/riscv-collab/riscv-openjdk/pull/17
> - https://github.com/riscv-collab/riscv-openjdk/pull/14
> @feilongjiang , do you know any reason why first two (string_equals & string_compare) wasn't ever integrated ?
At that time, we were focused on upstreaming the risc-v port. The misaligned access issues for those intrinsics are not a high priority. So we just reverted string_equals changes, and string_compare was closed before being integrated.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13645#issuecomment-1536216946
More information about the hotspot-dev
mailing list