Integrated: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at

Matias Saavedra Silva matsaave at openjdk.org
Fri May 5 14:28:27 UTC 2023


On Wed, 3 May 2023 19:18:18 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The set of functions in constantpool.hpp used for grabbing references at a certain index have cached and uncached variants which have different meanings for the index they take as an argument. In the implementation of these functions, the `uncached` boolean is checks alongside whether or not the cache has been created, but this is redundant since, if the cache has been created, the bytecode operands have been rewritten. This change replaces some of the calls with the uncached variant which expects a constant pool index as input so that the "cached" calls can take in rewritten indices. Verified with tier1-5 tests.

This pull request has now been integrated.

Changeset: 6fe959c6
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6fe959c62d6475b8f4c9ada2a8eb7b36d22d5e5e
Stats:     27 lines in 5 files changed: 3 ins; 0 del; 24 mod

8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at

Co-authored-by: Ioi Lam <iklam at openjdk.org>
Reviewed-by: coleenp, fparain

-------------

PR: https://git.openjdk.org/jdk/pull/13786


More information about the hotspot-dev mailing list