RFR: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing [v9]

[Thomas Stuefe]

On Fri, 5 May 2023 14:04:15 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Add test
>>  - Fix and strengthen print_stack_location
>>  - Missed variable rename
>>  - Copyright
>>  - Rework logic and use continuation state for reattempts
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Restructure os::print_register_info interface
>>  - Code syle and line length
>>  - Merge Fix
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/2009dc2b...2e12b4a5
>
> src/hotspot/share/utilities/vmError.cpp line 180:
> 
>> 178:   static const size_t  stack_size   = thread != nullptr
>> 179:                                     ? thread->stack_size()
>> 180:                                     : os::current_stack_size();
> 
> Why even bother with thread? If you want this to work without Thread*, you may just as well just use the os::current_stack_xxx() functions. 
> 
> OTOH I think it would also be perfectly acceptable to just use Thread*, since we have that in 99% of cases, and if Thread is null to assume that we have enough headroom.

I also would not bother making these vars static. Your intent was optimization, right, since we should only call this for one thread? But its surprising in the case we ever want to call this from different threads.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11017#discussion_r1186139631