RFR: 8306843: JVMTI tag map extremely slow after JDK-8292741 [v2]

[David Holmes]

On Mon, 8 May 2023 04:21:01 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove return variable from remove lambda, fix formatting.
>
> src/hotspot/share/utilities/resourceHash.hpp line 147:
> 
>> 145:   */
>> 146:   bool put_fast(K const& key, V const& value) {
>> 147:     unsigned hv = HASH(key);
> 
> I think `put_fast` is not clear enough. Maybe `put_must_be_absent()` or something more concise.

I would suggest `put_when_absent` to complement `put_if_absent` - with suitable descriptive comments of course.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13818#discussion_r1187035245