RFR: 8307517: Add VMErrorCallback infrastructure to extend hs_err dumping
Stefan Karlsson
stefank at openjdk.org
Mon May 8 06:35:24 UTC 2023
On Mon, 8 May 2023 06:14:21 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> I was treading in Runtime code and Coleen usually wants to use cached-away Thread pointers instead of calling Thread::current() repeatedly. I'm fine with either solution.
>
> Given the context it would have to be `Thread::current_or_null_safe()`. But yes we prefer not to re-materialize the current thread if we already have it at hand.
Could you explain why it would have to be `Thread::current_or_null_safe()`? The constructor and destructor are run in "normal" JVM code and not in the error handler.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13824#discussion_r1187072902
More information about the hotspot-dev
mailing list