RFR: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive [v2]

[Ashutosh Mehra]

On Tue, 25 Apr 2023 22:10:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Remove unshareable flags in Method and InstanceKlass
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8306460
>>  - 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Yes, you're right, all these flags shouldn't be in the archive.  I have a patch for JDK-8306851 which will make it easier to unset all of these flags (except has_loops/has_loops_init, which we want set in the archive).  Maybe this change should wait.

@coleenp I have updated this PR with additional commit to clear other flags as well and, as mentioned in my previous comment, added asserts for `is_old`, `is_obsolete`, and `is_deleted`. Can you please review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13652#issuecomment-1538342372