RFR: 8291555: Implement alternative fast-locking scheme [v78]

Thomas Stuefe stuefe at openjdk.org
Mon May 8 17:40:41 UTC 2023


On Mon, 8 May 2023 17:04:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only allow lock-stack verification for owning Java threads or at safepoints
>
> src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp line 218:
> 
>> 216: 
>> 217:   if (LockingMode == LM_LIGHTWEIGHT) {
>> 218:     log_trace(fastlock)("C1_MacroAssembler::lock fast");
> 
> Here and later: I don't think we need these log statements?

They had been helpful during development, to verify code generation. Going forward they can be scrapped, but lets do that in a follow-up PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1187707911


More information about the hotspot-dev mailing list