RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v9]

Alex Menkov amenkov at openjdk.org
Mon May 8 22:45:29 UTC 2023


On Sat, 6 May 2023 09:35:28 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> I mean the pieces of the code that set and use _is_top_frame/_last_entry_frame are close so it's easier to see the logic
>
> I'd say that it will be even better to find out what are manipulations with these instance fields. They are defined in class scope anyway. Also, you can place the definition of function `report_native_frame_refs()` right after `do_frame()` definition, so they occurrences will be still close.
> I think, it is more important to see the whole logics of the `do_frame()` with less cascading levels.
> You can give it a try and see the advantage.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1187961682


More information about the hotspot-dev mailing list