RFR: 8139457: Array bases are aligned at HeapWord granularity [v33]

Coleen Phillimore coleenp at openjdk.org
Tue May 9 20:31:40 UTC 2023


On Mon, 8 May 2023 20:14:43 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> See [JDK-8139457](https://bugs.openjdk.org/browse/JDK-8139457) for details.
>> 
>> Basically, when running with -XX:-UseCompressedClassPointers, arrays will have a gap between the length field and the first array element, because array elements will only start at word-aligned offsets. This is not necessary for smaller-than-word elements.
>> 
>> Also, while it is not very important now, it will become very important with Lilliput, which eliminates the Klass field and would always put the length field at offset 8, and leave a gap between offset 12 and 16.
>> 
>> Testing:
>>  - [x] runtime/FieldLayout/ArrayBaseOffsets.java (x86_64, x86_32, aarch64, arm, riscv, s390)
>>  - [x] bootcycle (x86_64, x86_32, aarch64, arm, riscv, s390)
>>  - [x] tier1 (x86_64, x86_32, aarch64, riscv)
>>  - [x] tier2 (x86_64, aarch64, riscv)
>>  - [x] tier3 (x86_64, riscv)
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix calls to removed instanceOopDesc::header_size()

I was looking at this again, and my review is NOT a full review.  I only reviewed the metadata changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/11044#issuecomment-1540847025


More information about the hotspot-dev mailing list