RFR: 8303942: os::write should write completely [v7]

David Holmes dholmes at openjdk.org
Wed May 10 07:20:19 UTC 2023


On Tue, 9 May 2023 10:46:15 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> "@mgronlun why does this code break the write up into INT_MAX chunks? Is the incoming len parameter really potentially not containable in a size_t? Using intptr_t for a length seems suspect."
> 
> I think it has mostly to do with legacy os::write() implementations and being able to write completely on all platforms.
> 
> The len was size_t up until this bug: https://bugs.openjdk.org/browse/JDK-8252090

Looks like there is an opportunity to clean that code up now then.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13750#issuecomment-1541475568


More information about the hotspot-dev mailing list