RFR: JDK-8307810: Consistently use LockingMode instead of UseHeavyMonitors [v4]
David Holmes
dholmes at openjdk.org
Thu May 11 01:27:46 UTC 2023
On Wed, 10 May 2023 15:49:38 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> [JDK-8291555](https://bugs.openjdk.org/browse/JDK-8291555) phased out UseHeavyMonitors in favor of LockingMode=0. We forgot to apply these changes to PPC and S390.
>>
>> Since UseHeavyMonitors implies LockingMode, but not vice versa, we now have a mismatch if JVM is started with LockingMode=0 but without UseHeavyMonitors. That leads to crashes.
>>
>> The patch fixes that, and in addition makes sure that if LockingMode=0 is set, we are setting UseHeavyMonitors too.
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8307810-use-lockingmode-instead-of-useheavymonitors
> - Merge branch 'master' into JDK-8307810-use-lockingmode-instead-of-useheavymonitors
> - Dont modify UseHeavyMonitors
> - JDK-8307810-use-lockingmode-instead-of-useheavymonitors
Seems fine.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13900#pullrequestreview-1421586470
More information about the hotspot-dev
mailing list