RFR: 8306541: Refactor collection set candidate handling to prepare for JDK-8140326 [v9]

Albert Mingkun Yang ayang at openjdk.org
Thu May 11 14:55:55 UTC 2023


On Thu, 11 May 2023 14:02:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp line 43:
>> 
>>> 41: 
>>> 42: // A set of HeapRegion*.
>>> 43: class G1CollectionSetRegionList {
>> 
>> Now that this is just a region-list, maybe drop the "CollectionSet" part?
>
> I would like to keep the name as is and avoid generalizations that are unnecessary at this time. If there is additional use for it, we can always factor it out.

It's mostly to avoid confusion. The two even have the same length...


G1CollectionCandidateList
G1CollectionSetRegionList

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13666#discussion_r1191304108


More information about the hotspot-dev mailing list