RFR: JDK-8302736: Major performance regression in Math.log on aarch64
Tobias Holenstein
tholenstein at openjdk.org
Thu May 11 14:59:43 UTC 2023
On Wed, 10 May 2023 13:05:00 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> Nice analysis, Toby. This point fix looks good to me.
>>
>> As @theRealAph mentioned in the bug comments, and since there are other coarse-grained usages of `ThreadWXEnable` in the code (for example, in the `VM/JTR_ENTRY` macros), please file a follow-up RFE to improve this situation. The `ThreadWXEnable` should be as close as possible to the code that does the actual write access to the code cache.
>
>>
>
>
>
>> Nice analysis, Toby. This point fix looks good to me.
>>
>> As @theRealAph mentioned in the bug comments, and since there are other coarse-grained usages of `ThreadWXEnable` in the code (for example, in the `VM/JTR_ENTRY` macros), please file a follow-up RFE to improve this situation. The `ThreadWXEnable` should be as close as possible to the code that does the actual write access to the code cache.
>
> Thanks! I filed https://bugs.openjdk.org/browse/JDK-8307817
> @tobiasholenstein what testing has been done on this? We may need to run all tiers (1-8) to ensure we have completely covered all the code paths affected. Thanks.
All tiers (1-10) were run and passed
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13606#issuecomment-1544145886
More information about the hotspot-dev
mailing list