RFR: 8286597: Implement PollerProvider on AIX [v4]
Tyler Steele
tsteele at openjdk.org
Thu May 11 16:58:16 UTC 2023
On Thu, 11 May 2023 05:34:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Tyler Steele has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Improve comment in ContinuationHelper procedures
>> - Completes removal of include from adlc/main.cpp
>
> test/jdk/java/net/vthread/BlockingSocketOps.java line 192:
>
>> 190: s2.setSoLinger(true, 0);
>> 191: s2.close();
>> 192: });
>
> This is okay but shouldn't be necessary as the linger option was set before starting the thread to close the other end. The linger setting is per socket rather than per-thread so curious why the original was problematic on AIX.
This test was my last barrier to integration before I cleaned up the code. Now it seems that it is passing unmodified. So, I've reverted the change. I may see this failure again, but as you mentioned the test shouldn't need to be changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13452#discussion_r1191459215
More information about the hotspot-dev
mailing list