RFR: 8307190: Refactor ref_at methods in Constant Pool

[Coleen Phillimore]

On Thu, 11 May 2023 18:06:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> In anticipation of [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996), some of the accessors in constantpool.cpp need to be updated. The CPCache rework introduces multiple new meanings to the index argument passed to these functions, so they need to be restructured in a way that facilitates different paths depending on the input. For this enhancement, the bytecode is propagated by the callers to determine how to handle the index. Thanks to this and JDK-8307306, `bool uncached` is no longer needed in these functions.
>> 
>> Tests have been altered to suit the changes to JVMCI. Verified with tier1-5 tests.
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java line 438:
> 
>> 436:      *
>> 437:      * @param which constant pool index or constant pool cache index
>> 438:      * @param opcode bytecode
> 
> Is this a param?  You should remove the jvmci changes because they're not needed for this change.

Or should the comment say that 'which' is the constant pool index only in this case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13872#discussion_r1191725184