RFR: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing [v9]

[Axel Boldt-Christmas]

On Fri, 5 May 2023 14:16:47 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Add test
>>  - Fix and strengthen print_stack_location
>>  - Missed variable rename
>>  - Copyright
>>  - Rework logic and use continuation state for reattempts
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Restructure os::print_register_info interface
>>  - Code syle and line length
>>  - Merge Fix
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/2009dc2b...2e12b4a5
>
> src/hotspot/share/utilities/vmError.cpp line 201:
> 
>> 199: #endif // ASSERT
>> 200: 
>> 201: bool VMError::should_stop_reattempt_step(const char* &reason) {
> 
> I had to read this twice to see the "stop" in the name :-) 
> 
> I would prefer the logic to be inverse and this function to be named "can_reattempt_step". But since this is a matter of taste, I leave it up to you.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11017#discussion_r1193418823