RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]
JoKern65
duke at openjdk.org
Mon May 15 09:55:45 UTC 2023
On Mon, 15 May 2023 09:32:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> I see, so `size` is kind of macro-like, and is just textually splicing its argument expression into another expression.
>> And without the added parens the resulting full expression for the assert isn't checking what's intended, due
>> to operator precedence.
>>
>> This is in generated source; it might be better to find the code generator (somewhere in adlc) and change it
>> to add appropriate parens, as there may be other similar places (both here and for other platforms) that
>> aren't doing what's intended but are not triggering warnings.
>
> Such a fix of adlc is probably out of scope for this change though. We should probably have a separate bug for that.
And what should I use as a workaround meanwhile to get our new compiler through?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13953#discussion_r1193605092
More information about the hotspot-dev
mailing list