RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

[Martin Doerr]

On Fri, 12 May 2023 16:16:01 GMT, JoKern65 <duke at openjdk.org> wrote:

>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed by small adjustments.
>> A lot of those changes are in hotspot, some might be somewhere else in the OpenJDK C/C++ code.
>> With this PR we address only the platform dependent code changes.
>
> JoKern65 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cosmetic changes

Thanks for addressing all the warnings! Looks basically good to me. Some details need to get checked.

src/hotspot/os/aix/os_aix.cpp line 677:

> 675: #ifdef AIX_XLC_GE_17
> 676: #include "alloca.h"
> 677: #endif

Includes should better be at the beginning of the file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13953#pullrequestreview-1426444262
PR Review Comment: https://git.openjdk.org/jdk/pull/13953#discussion_r1193770194