RFR: 8308092: Replace NULL with nullptr in gc/x

David Holmes dholmes at openjdk.org
Tue May 16 07:39:45 UTC 2023


On Mon, 15 May 2023 11:40:26 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Replace NULL with nullptr in gc/x. We've already done this work for Generational ZGC, but left it for the Singlegen ZGC code.

Looks good. There are 5 casts that should hopefully no longer be needed.

Thanks.

src/hotspot/share/gc/x/xBarrier.inline.hpp line 229:

> 227: //
> 228: inline oop XBarrier::load_barrier_on_oop(oop o) {
> 229:   return load_barrier_on_oop_field_preloaded((oop*)nullptr, o);

Casts should not be needed on `nullptr`.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13984#pullrequestreview-1427917422
PR Review Comment: https://git.openjdk.org/jdk/pull/13984#discussion_r1194740745


More information about the hotspot-dev mailing list