RFR: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive [v2]

Coleen Phillimore coleenp at openjdk.org
Tue May 16 16:37:50 UTC 2023


On Sat, 6 May 2023 14:02:17 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> This patch clears the method's "queued_for_compilation" flag when dumping the method in CDS archive. Also added an assert in `Method::restore_unshareable_info()` that the method being restored should not have that flag set.
>
> Ashutosh Mehra has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Remove unshareable flags in Method and InstanceKlass
>    
>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8306460
>  - 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
>    
>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

I just rechecked the code and what you have is right.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13652#pullrequestreview-1428984371


More information about the hotspot-dev mailing list