RFR: 8308252: Refactor line-by-line file reading code

Ioi Lam iklam at openjdk.org
Wed May 17 03:53:03 UTC 2023


I extracted the `get_line()` code from `CompileReplay` and put it in a utility class so that it can be used by `ClassListParser` as well. A few notable changes:

- Simplified the API
- Changed the buffer size to a size_t
- Added size overflow and OOM checks
- Brought over the `fdopen` logic from `ClassListParser` for handling long path names on Windows. (I don't know how valid this is nowadays, but I don't want to drop it in a refactoring PR).

-------------

Commit messages:
 - 8308252: Refactor line-by-line file reading code

Changes: https://git.openjdk.org/jdk/pull/14025/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14025&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8308252
  Stats: 233 lines in 5 files changed: 163 ins; 49 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/14025.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14025/head:pull/14025

PR: https://git.openjdk.org/jdk/pull/14025


More information about the hotspot-dev mailing list