RFR: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing [v9]

Wed May 17 07:11:07 UTC 2023

On Fri, 5 May 2023 11:07:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Add test
>>  - Fix and strengthen print_stack_location
>>  - Missed variable rename
>>  - Copyright
>>  - Rework logic and use continuation state for reattempts
>>  - Merge remote-tracking branch 'upstream_jdk/master' into vmerror_report_register_stack_reentrant
>>  - Restructure os::print_register_info interface
>>  - Code syle and line length
>>  - Merge Fix
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/2009dc2b...2e12b4a5
>
> It is certainly useful. I mainly regret the added complexity.
> 
> I wonder whether we need the stack headroom probing. AFAICS you limit the number of reattempts, maybe that's already enough. In earlier iterations of this patch, there were more reattempts possible.

@tstuefe @fisk Thanks for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/11017#issuecomment-1550863269