RFR: 8308000: add PopFrame support for virtual threads

[Serguei Spitsyn]

On Tue, 16 May 2023 23:15:36 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> This enhancement adds `PopFrame` support for virtual threads. The spec defines minimal support that the JVMTI `PopFrame` can be used for a virtual thread suspended an an event. 
>> Actually, the `PopFrame` can supports suspended and mounted virtual threads. 
>> 
>> CSR (approved): https://bugs.openjdk.org/browse/JDK-8308001: add PopFrame support for virtual threads
>> 
>> Testing:
>> New test was developed: `serviceability/vthread/PopFrameTest`.
>> Submitted mach5 tiers 1-6 are good.
>> TBD: rerun mach5 tiers 1-6 at the end of review again if necessary.
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp line 62:
> 
>> 60: 
>> 61:   err = jvmti->PopFrame(thread);
>> 62:   LOG("Main: popFrame: PopFrame returned code: %s (%d)\n", TranslateError(err), err);
> 
> check_jvmti_status prints return code and translated error if fails. So this line is not needed,

This log is not for error handling but for logging, so I'd like to keep it.
The error code can be not printed but I also prefer to keep it to have it in sync with error handling.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14002#discussion_r1196115359