RFR: 8308000: add PopFrame support for virtual threads
Serguei Spitsyn
sspitsyn at openjdk.org
Wed May 17 09:16:46 UTC 2023
On Tue, 16 May 2023 23:42:16 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> This enhancement adds `PopFrame` support for virtual threads. The spec defines minimal support that the JVMTI `PopFrame` can be used for a virtual thread suspended an an event.
>> Actually, the `PopFrame` can supports suspended and mounted virtual threads.
>>
>> CSR (approved): https://bugs.openjdk.org/browse/JDK-8308001: add PopFrame support for virtual threads
>>
>> Testing:
>> New test was developed: `serviceability/vthread/PopFrameTest`.
>> Submitted mach5 tiers 1-6 are good.
>> TBD: rerun mach5 tiers 1-6 at the end of review again if necessary.
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/PopFrameTest.java line 152:
>
>> 150:
>> 151: log("\nMain #B.3: unsuspended, call PopFrame on own thread");
>> 152: ensureAtBreakpoint();
>
> Am I understand correctly, that test expect here to pop frame and immediately get to the same breakpoint?
Yes, it is correct. The method `B()` is called twice in the method `run()` at lines `212` and `215`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14002#discussion_r1196192495
More information about the hotspot-dev
mailing list