RFR: 8307190: Refactor ref_at methods in Constant Pool [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Wed May 17 17:40:01 UTC 2023
> In anticipation of [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996), some of the accessors in constantpool.cpp need to be updated. The CPCache rework introduces multiple new meanings to the index argument passed to these functions, so they need to be restructured in a way that facilitates different paths depending on the input. For this enhancement, the bytecode is propagated by the callers to determine how to handle the index. Thanks to this and JDK-8307306, `bool uncached` is no longer needed in these functions.
>
> Tests have been altered to suit the changes to JVMCI. Verified with tier1-5 tests.
Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Fixed javadoc and test cleanup
- Merge branch 'master' into refactor_ref_at_8307190
- Fixed comments and copyright
- Changed compilerToVM methods
- Coleen comments
- 8307190: Refactor ref_at methods in Constant Pool
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13872/files
- new: https://git.openjdk.org/jdk/pull/13872/files/dd67dbed..2b1bf47d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13872&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13872&range=00-01
Stats: 96605 lines in 1561 files changed: 77989 ins; 7673 del; 10943 mod
Patch: https://git.openjdk.org/jdk/pull/13872.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13872/head:pull/13872
PR: https://git.openjdk.org/jdk/pull/13872
More information about the hotspot-dev
mailing list