RFR: 8307190: Refactor ref_at methods in Constant Pool [v2]

[Coleen Phillimore]

On Wed, 17 May 2023 20:08:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Fixed javadoc and test cleanup
>>  - Merge branch 'master' into refactor_ref_at_8307190
>>  - Fixed comments and copyright
>>  - Changed compilerToVM methods
>>  - Coleen comments
>>  - 8307190: Refactor ref_at methods in Constant Pool
>
> test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.java line 115:
> 
>> 113:             break;
>> 114:           default:
>> 115:             throw new Error("Unexpected consant pool entry");
> 
> Typo: consant

I wonder if this should be refactored into a little function toOpcodeType() or something like that.  It probably should be for these tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13872#discussion_r1197003782