RFR: 8307865: Invalid is_in_any_VTMS_transition() check in post_dynamic_code_generated_while_holding_locks [v2]

Chris Plummer cjplummer at openjdk.org
Thu May 18 23:38:58 UTC 2023


On Thu, 18 May 2023 23:34:03 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Method post_dynamic_code_generated_while_holding_locks()
>> register stubs and might be called during VTMT transitions.
>> At least it is called in tmp VTMT transition, and stubs might be generated during standard VTMT transition.
>> 
>> The method doesn't post event but just register stub for later posting so it might be called during transition.
>> 
>> Also, the test has been updated to test virtual threads. It crashed before fix and start passing after fix.
>> Additionally, checked this test with Xcomp, run tier1/tier5 and some stress testing
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - fixed comments
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8307865
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8307865
>  - 8307865: Invalid is_in_any_VTMS_transition() check in post_dynamic_code_generated_while_holding_locks

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13921#pullrequestreview-1433582512


More information about the hotspot-dev mailing list