RFR: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack [v10]

[Emanuel Peter]

On Thu, 18 May 2023 10:42:01 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Second batch of suggestions from @chhagedorn
>
> Not really a review, just some drive-by comments.

@kimbarrett @jcking I wonder if it is not better to just avoid any move constructors/assign. We would have to convert the "return value optimization" cases (i.e. return contrainer by value, and it being captured by the move constructor), and instead create containers outside, and pass them in as references ("pseudo-output"). It is a bit ugly, but maybe more understandable than the move semantics?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13833#issuecomment-1554005791